[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexppg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: viglesiasce

If they are not already assigned, you can assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Hi @alexppg. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

I'm not sure why it says that I fail the DCO. I've signed with my main e-mail, but it wants me to set the corporate mail.

@alexppg the DCO checks that the signing email corresponds to the email in the commit itself.

git config user.email

Thanks @vsliouniaev, I've change it. I believe there's nothing to be done on my side until somebody reviews it, the lint that fails won't pass until some maintainer is asigned.

Since you are submitting this chart to the repository, wouldn't it make sense that you should add yourself as the maintainer?

No problem @mvasilenko, but I believe I can't add myself like that and make the tests pass. In a prior commit I added myself to the maintainers section but this check says I'm not validated as a maintainer, and I don't know how it validates it.

ping @viglesiasce @foxish

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Just to keep this open as the bot is trying to close this. Is there anything still to be done here?

@ntavares Somebody needs to revise it, as far as I know I don't have to do anything.

hey @alexppg

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

I'd like to that, but right now I'm not able. I'll try to convince my company to do it, but for now is no possible. It's a problem @maorfr ?

hey @alexppg, thanks for your reply!

it is an effort problem. chart maintainers are over loaded, so reviewing a new chart usually takes a long time. with that said, the way forward is not this repository, but rather helm hub! :)

Here are some things to consider if you are exploring hosting your own charts repository (copied from a similar PR):

I think that you totally should host your own charts!
This will give you more freedom around management, and you will not be blocked by us (maintainers).

This means that when users want to install your chart, instead of installing them from stable, they will install it from (for example) mycompany-charts:

$ helm install --name my-release mycompany-charts/mychart
Here are some instructions about how to host your own charts repo:
https://github.com/helm/hub/blob/master/docs/github.md#github-pages-as-a-repository

In order for people to find out about your charts repo, you should add it to helm hub:
https://hub.helm.sh/

Here are some instructions about how to add your charts repo to helm hub:
https://github.com/helm/hub#how-to-add-your-helm-charts

Hope that answered all your questions! :)

Thanks @maorfr ! I'll sure like to do that, because of all the reasons you mentioned. But as I said, I don't think this will be possible in a short time, so I'd like to maintain this chart here. Sorry and thanks for your kind explanation!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

This issue is being automatically closed due to inactivity.